rwlock

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>

http/auth.go

@@ -29,6 +29,9 @@ type signupBody struct {
 }
 
 func (e *Env) signupHandler(w http.ResponseWriter, r *http.Request) {
+	e.mux.RLock()
+	defer e.mux.RUnlock()
+
 	if !e.Settings.Signup {
 		httpErr(w, r, http.StatusForbidden, nil)
 		return

http/http.go

@@ -29,7 +29,7 @@ type Env struct {
 	Auther   types.Auther
 	Settings *types.Settings
 	Store    *types.Store
-	mux      sync.Mutex // settings mutex for Auther, Runner and Settings changes.
+	mux      sync.RWMutex // settings mutex for Settings changes.
 }
 
 // Handler ...

http/settings.go

@@ -23,6 +23,9 @@ func (e *Env) settingsGetHandler(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
+	e.mux.RLock()
+	defer e.mux.RUnlock()
+
 	data := &settingsData{
 		Signup:   e.Settings.Signup,
 		Defaults: e.Settings.Defaults,

http/static.go

@@ -15,6 +15,9 @@ import (
 )
 
 func (e *Env) getStaticData() map[string]interface{} {
+	e.mux.RLock()
+	defer e.mux.RUnlock()
+
 	staticURL := strings.TrimPrefix(e.Settings.BaseURL+"/static", "/")
 
 	data := map[string]interface{}{
@@ -85,6 +88,9 @@ func (e *Env) getStaticHandlers() (http.Handler, http.Handler) {
 	})
 
 	static := http.StripPrefix("/static/", http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		e.mux.RLock()
+		defer e.mux.RUnlock()
+
 		if e.Settings.Branding.Files != "" {
 			if strings.HasPrefix(r.URL.Path, "img/") {
 				path := filepath.Join(e.Settings.Branding.Files, r.URL.Path)

http/websockets.go

@@ -61,7 +61,10 @@ func (e *Env) commandsHandler(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
+	e.mux.RLock()
 	command, err := e.Settings.ParseCommand(raw)
+	e.mux.RUnlock()
+
 	if err != nil {
 		err := conn.WriteMessage(websocket.TextMessage, []byte(err.Error()))
 		if err != nil {