refactor: init audit logger when first used (#2369)

audit/audit.go

@@ -4,10 +4,9 @@ import "log"
 
 var auditLogger *log.Logger
 
-func init() {
+func getAuditLogger() *log.Logger {
-	setupAuditLogger()
+	if auditLogger == nil {
-}
-
-func setupAuditLogger() {
 		auditLogger = log.Default()
+	}
+	return auditLogger
 }

audit/audit_test.go

@@ -8,9 +8,12 @@ import (
 func TestSetupAuditLogger(t *testing.T) {
 	auditLogger = nil
 
-	setupAuditLogger()
+	result := getAuditLogger()
 
-	if auditLogger != log.Default() {
+	if result != log.Default() {
-		t.Error("Audit logger isn't set to the default logger!")
+		t.Error("Audit logger wasn't initialized with the default logger!")
+	}
+	if auditLogger != result {
+		t.Error("Audit logger wasn't set globally!")
 	}
 }

audit/log.go

@@ -22,5 +22,5 @@ func createLogMessage(info ResourceActivity) string {
 }
 
 func logToAuditLogger(message string) {
-	auditLogger.Println(message)
+	getAuditLogger().Println(message)
 }