Code review changes

This commit is contained in:
chief 2020-11-17 20:15:10 -05:00
parent f8b5e869fd
commit 279f4c84f8
2 changed files with 10 additions and 7 deletions

View File

@ -133,14 +133,14 @@ export default {
}
},
async mounted () {
window.addEventListener('keyup', this.key)
window.addEventListener('keydown', this.key)
this.$store.commit('setPreviewMode', true)
this.listing = this.oldReq.items
this.$root.$on('preview_deleted', this.deleted)
this.$root.$on('preview-deleted', this.deleted)
this.updatePreview()
},
beforeDestroy () {
window.removeEventListener('keyup', this.key)
window.removeEventListener('keydown', this.key)
this.$store.commit('setPreviewMode', false)
},
methods: {
@ -153,8 +153,10 @@ export default {
if (this.hasNext) {
this.next()
} else {
} else if (!this.hasPrevious && !this.hasNext == true) {
this.back()
} else {
this.prev()
}
},
back () {
@ -169,7 +171,6 @@ export default {
this.$router.push({ path: this.nextLink })
},
key (event) {
event.preventDefault()
if (this.show !== null) {
return

View File

@ -31,7 +31,6 @@ export default {
methods: {
...mapMutations(['closeHovers']),
submit: async function () {
this.closeHovers()
buttons.loading('delete')
try {
@ -39,10 +38,13 @@ export default {
await api.remove(this.$route.path)
buttons.success('delete')
this.$root.$emit('preview_deleted', this.$route.path)
this.$root.$emit('preview-deleted', this.$route.path)
this.closeHovers()
return
}
this.closeHovers()
if (this.selectedCount === 0) {
return
}